Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"homepage" setting in package.json doesn't work if it's set to https #1335

Closed
twe4ked opened this issue Jan 2, 2017 · 5 comments
Closed

Comments

@twe4ked
Copy link

twe4ked commented Jan 2, 2017

Description

If I set homepage to:

"homepage": "https://twe4ked.github.io/api-docs/"

The asset links point to /.

If it set it to:

"homepage": "http://twe4ked.github.io/api-docs/"

I get the expected behaviour, the asset links point to /api-docs/.

Very similar to this (closed) existing issue: #478

Environment

Run these commands in the project folder and fill in their results:

  1. npm ls react-scripts (if you haven’t ejected):
[email protected] /Users/odin/Dev/twe4ked/api-docs
└── [email protected]
  1. node -v:
v5.2.0
  1. npm -v:
3.10.8

Then, specify:

  1. Operating system:

MacOS 10.12

  1. Browser and version:

N/A

Reproducible Demo

https://github.com/twe4ked/api-docs

@gaearon
Copy link
Contributor

gaearon commented Jan 3, 2017

This looks like a bug.
#478 is different because its author didn’t specify homepage at all.

Would you like to look into why this happens and maybe help us fix it?

@bunshar
Copy link
Contributor

bunshar commented Jan 9, 2017

@twe4ked are you still getting the error.
I checked your repo with node ver 5.5 + and got no issues. Can you try with node 6+ and if ok we can close the ticket.

@gaearon
Copy link
Contributor

gaearon commented Jan 9, 2017

We should make sure it works with all Node versions >= 4 because that’s the versions we support.

@twe4ked
Copy link
Author

twe4ked commented Jan 10, 2017

I just tried making a sample app and I can't reproduce it again. Perhaps it was something specific to my setup at the time. Thanks for the help.

@twe4ked twe4ked closed this as completed Jan 10, 2017
@gaearon
Copy link
Contributor

gaearon commented Jan 10, 2017

Interesting. Let us know if you have it again.

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants