Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable linting on yarn start #10414

Closed
aprilmintacpineda opened this issue Jan 21, 2021 · 6 comments
Closed

disable linting on yarn start #10414

aprilmintacpineda opened this issue Jan 21, 2021 · 6 comments

Comments

@aprilmintacpineda
Copy link

aprilmintacpineda commented Jan 21, 2021

Is your proposal related to a problem?

We should have the option to disable linting on yarn start, we already have an IDE that integrates with eslint and prettier, we use git-hooks to lint and format files on commit, it's pretty annoying to have it on start as well and it also makes dev really slow.

Describe the solution you'd like

add a flag --no-lint to disable all linting and purely build and serve on yarn start

Describe alternatives you've considered

Used patch-package

Additional context

Nothing.

@aprilmintacpineda aprilmintacpineda changed the title disable eslint on yarn start disable linting on yarn start Jan 21, 2021
@Chris-Thompson-bnsf
Copy link

Seems related to these: #9886, #10154

@aprilmintacpineda
Copy link
Author

@Chris-Thompson-bnsf not exactly, since those are specifically about slow builds, this is more about how unnecessary it is to run the linting on start when we already other integrations in place to ensure it's being followed.

@Chris-Thompson-bnsf
Copy link

@aprilmintacpineda There are similar comments about the linting in those discussions, and at least one of them has some workarounds such as disabling or enabling the cache for linting. More of an FYI in case you're looking for workarounds in the mean time.

@aprilmintacpineda
Copy link
Author

Yes, I used patch-package

@aprilmintacpineda
Copy link
Author

I just found out that on .env we can add DISABLE_ESLINT_PLUGIN=true

@gatezh
Copy link

gatezh commented Mar 30, 2021

There seems to be a better option than completely disabling linter.
Setting up ESLINT_NO_DEV_ERRORS=true flag in .env file solves the problem.
Found here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants