From db8664c36c09f6f81485d785816f5f92d71af613 Mon Sep 17 00:00:00 2001 From: Chris Laughlin Date: Sat, 13 Jan 2018 01:05:18 +0000 Subject: [PATCH] Enable `getter-return` rule as a warning (#3723) * Updating ESlint to ^4.15.0 and adding new rules to config * remoning style rule and auto fixing breakages from new rules * Removing implicit-arrow-linebreak style rule * adding new rule to eslint config project * updating react scripts eslint version * Pinning version. * Changing getter-return to warn * Update package.json * Update .eslintrc --- packages/eslint-config-react-app/index.js | 1 + packages/react-scripts/package.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index 836dd5aa0ae..2912f8ad603 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -238,6 +238,7 @@ module.exports = { 'Please use import() instead. More info: https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#code-splitting', }, ], + 'getter-return': 'warn', // https://github.com/benmosher/eslint-plugin-import/tree/master/docs/rules 'import/first': 'error', diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json index 04d294bc2e4..87f0693fcc7 100644 --- a/packages/react-scripts/package.json +++ b/packages/react-scripts/package.json @@ -34,7 +34,7 @@ "css-loader": "0.28.7", "dotenv": "4.0.0", "dotenv-expand": "4.0.1", - "eslint": "4.10.0", + "eslint": "4.15.0", "eslint-config-react-app": "^2.0.1", "eslint-loader": "1.9.0", "eslint-plugin-flowtype": "2.39.1",