From 3190e4f4a99b8c54acb0993d92fec8a859889a28 Mon Sep 17 00:00:00 2001 From: Rohit Singhal Date: Fri, 31 Jan 2020 20:39:20 +0530 Subject: [PATCH] Handle service worker error in Firefox (#8272) * Handle service worker error in Firefox See https://bugzilla.mozilla.org/show_bug.cgi?id=1429714 for more details. * Update serviceWorker.js --- .../template/src/serviceWorker.ts | 10 +++++++--- packages/cra-template/template/src/serviceWorker.js | 10 +++++++--- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/packages/cra-template-typescript/template/src/serviceWorker.ts b/packages/cra-template-typescript/template/src/serviceWorker.ts index d5f0275a77d..b09523f155e 100644 --- a/packages/cra-template-typescript/template/src/serviceWorker.ts +++ b/packages/cra-template-typescript/template/src/serviceWorker.ts @@ -138,8 +138,12 @@ function checkValidServiceWorker(swUrl: string, config?: Config) { export function unregister() { if ('serviceWorker' in navigator) { - navigator.serviceWorker.ready.then(registration => { - registration.unregister(); - }); + navigator.serviceWorker.ready + .then(registration => { + registration.unregister(); + }) + .catch(error => { + console.error(error.message); + }); } } diff --git a/packages/cra-template/template/src/serviceWorker.js b/packages/cra-template/template/src/serviceWorker.js index 8703ddb7ecb..c4838eb55f0 100644 --- a/packages/cra-template/template/src/serviceWorker.js +++ b/packages/cra-template/template/src/serviceWorker.js @@ -130,8 +130,12 @@ function checkValidServiceWorker(swUrl, config) { export function unregister() { if ('serviceWorker' in navigator) { - navigator.serviceWorker.ready.then(registration => { - registration.unregister(); - }); + navigator.serviceWorker.ready + .then(registration => { + registration.unregister(); + }) + .catch(error => { + console.error(error.message); + }); } }