From 1b6f58cf05e6ad11e14dcc436570f783fe7cb6fc Mon Sep 17 00:00:00 2001 From: Shubheksha Jalan Date: Mon, 26 Sep 2016 04:01:53 +0530 Subject: [PATCH] Forked react-scripts should retain the binary name (#754) * Forked react-scripts should retain the binary name * Forked react-scripts should retain the binary name -- fixed issue with regex * Forked react-scripts should retain the binary name -- fixed style nit --- packages/react-scripts/scripts/eject.js | 5 +---- packages/react-scripts/scripts/init.js | 8 ++++---- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/react-scripts/scripts/eject.js b/packages/react-scripts/scripts/eject.js index c0c498d12df..9eb6d4fd44c 100644 --- a/packages/react-scripts/scripts/eject.js +++ b/packages/react-scripts/scripts/eject.js @@ -94,10 +94,7 @@ prompt( delete appPackage.scripts['eject']; Object.keys(appPackage.scripts).forEach(function (key) { appPackage.scripts[key] = appPackage.scripts[key] - .replace( - new RegExp(ownPackageName + ' (\\w+)', 'g'), - 'node scripts/$1.js' - ); + .replace(/react-scripts (\w+)/g, 'node scripts/$1.js'); }); // Add Jest config diff --git a/packages/react-scripts/scripts/init.js b/packages/react-scripts/scripts/init.js index 222902a7413..cbefd413c29 100644 --- a/packages/react-scripts/scripts/init.js +++ b/packages/react-scripts/scripts/init.js @@ -24,10 +24,10 @@ module.exports = function(appPath, appName, verbose, originalDirectory) { // Setup the script rules appPackage.scripts = { - 'start': ownPackageName + ' start', - 'build': ownPackageName + ' build', - 'test': ownPackageName + ' test --env=jsdom', - 'eject': ownPackageName + ' eject' + 'start': 'react-scripts start', + 'build': 'react-scripts build', + 'test': 'react-scripts test --env=jsdom', + 'eject': 'react-scripts eject' }; fs.writeFileSync(