Skip to content

Commit 0b0265d

Browse files
committed
Use filter instead of if statement
1 parent 0959d09 commit 0b0265d

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

packages/react-scripts/scripts/utils/verifyPackageTree.js

+3-6
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const isESLintPluginEnabled = process.env.DISABLE_ESLINT_PLUGIN !== 'true';
1919
// in the tree will likely break your setup.
2020
// This is a relatively low-effort way to find common issues.
2121
function verifyPackageTree() {
22-
let depsToCheck = [
22+
const depsToCheck = [
2323
// These are packages most likely to break in practice.
2424
// See https://github.com/facebook/create-react-app/issues/1795 for reasons why.
2525
// I have not included Babel here because plugins typically don't import Babel (so it's not affected).
@@ -28,11 +28,8 @@ function verifyPackageTree() {
2828
'jest',
2929
'webpack',
3030
'webpack-dev-server',
31-
];
32-
33-
if (isESLintPluginEnabled) {
34-
depsToCheck = [...depsToCheck, 'babel-eslint', 'eslint'];
35-
}
31+
...(isESLintPluginEnabled && ['babel-eslint', 'eslint']),
32+
].filter(Boolean);
3633

3734
// Inlined from semver-regex, MIT license.
3835
// Don't want to make this a dependency after ejecting.

0 commit comments

Comments
 (0)