Skip to content

Commit

Permalink
Update platform010 & platform010-aarch64 symlinks
Browse files Browse the repository at this point in the history
Summary:
`1.76.0` release with fixes addressing the following:
* Release notes ([link](https://releases.rs/docs/1.76.0/))
  * Most notable is [#118054](rust-lang/rust#118054) manifesting as:
```
error: unused implementer of `futures::Future` that must be used
   --> fbcode/mlx/metalearner/housekeeper/housekeeper.rs:213:13
    |
213 |             self.ping_oncall(&oncall, usecases);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: futures do nothing unless you `.await` or poll them
    = note: requested on the command line with `-D unused-must-use`
```
* Changes in `search_index.js` spec for `rustdoc` ([link](https://github.com/rust-lang/rust/pull/118910/files#diff-3ac57789ddcd2856a3b4f0c444f2813315179bdbe55bb945fe64fcb27b53fee5L491))
* Split of `#![feature(exposed_provenance)]` ([link](rust-lang/rust#118487)) from [#95228](rust-lang/rust#95228)
* `buck2` OSS toolchain bump to `nightly-2023-12-11` just before [#11878](rust-lang/rust-clippy#11878) and a bunch of other clippy lint renames.

Reviewed By: dtolnay

Differential Revision: D53776867

fbshipit-source-id: 78db83d8cdd6b0abae2b94ed1075e67b501fcd73
  • Loading branch information
diliop authored and facebook-github-bot committed Feb 20, 2024
1 parent 892fb0a commit 9bcdeb7
Show file tree
Hide file tree
Showing 10 changed files with 15 additions and 13 deletions.
4 changes: 2 additions & 2 deletions HACKING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ cargo install --path=app/buck2
Or, alternatively, install it directly from GitHub:

```sh
rustup install nightly-2023-11-10
cargo +nightly-2023-11-10 install --git https://github.com/facebook/buck2.git buck2
rustup install nightly-2023-12-11
cargo +nightly-2023-12-11 install --git https://github.com/facebook/buck2.git buck2
```

### Side note: using [Nix] to compile the source
Expand Down
2 changes: 1 addition & 1 deletion app/buck2_audit_server/src/cell.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ impl AuditSubcommand for AuditCellCommand {
}

pub(crate) fn audit_cell(
aliases_to_resolve: &Vec<String>,
aliases_to_resolve: &[String],
aliases: bool,
cells: &CellResolver,
cwd: &ProjectRelativePath,
Expand Down
2 changes: 1 addition & 1 deletion app/buck2_build_api/src/deferred/calculation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ async fn compute_deferred(
impl DeferredCompute {
fn create_materializer_futs<'a>(
&'a self,
materialized_artifacts: &'a Vec<ArtifactGroup>,
materialized_artifacts: &'a [ArtifactGroup],
ctx: &'a DiceComputations,
span: &'a Lazy<Option<Span>, impl FnOnce() -> Option<Span>>,
) -> impl Future<Output = anyhow::Result<HashMap<Artifact, ProjectRelativePathBuf>>> + 'a
Expand Down
2 changes: 1 addition & 1 deletion app/buck2_critical_path/src/graph.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ pub struct Graph {

impl Graph {
#[inline]
pub fn iter_vertices(&self) -> impl Iterator<Item = VertexId> + DoubleEndedIterator {
pub fn iter_vertices(&self) -> impl DoubleEndedIterator<Item = VertexId> {
self.vertices.keys()
}

Expand Down
6 changes: 3 additions & 3 deletions app/buck2_critical_path/src/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,13 @@ where
Self(v, PhantomData)
}

pub fn keys(&self) -> impl Iterator<Item = AbstractVertexId<Kind>> + DoubleEndedIterator {
pub fn keys(&self) -> impl DoubleEndedIterator<Item = AbstractVertexId<Kind>> {
// By construction the length of this is always less than the maximum vertex id.
let len: u32 = self.0.len().try_into().unwrap();
(0..len).map(AbstractVertexId::new)
}

pub fn iter(&self) -> impl Iterator<Item = (AbstractVertexId<Kind>, &T)> + DoubleEndedIterator {
pub fn iter(&self) -> impl DoubleEndedIterator<Item = (AbstractVertexId<Kind>, &T)> {
self.keys().map(|k| (k, &self.0[k.0 as usize]))
}

Expand Down Expand Up @@ -208,7 +208,7 @@ where
Self(v)
}

pub fn iter(&self) -> impl Iterator<Item = (AbstractVertexId<Kind>, &K)> + DoubleEndedIterator {
pub fn iter(&self) -> impl DoubleEndedIterator<Item = (AbstractVertexId<Kind>, &K)> {
self.0.iter().map(|(key, idx)| (*idx, key))
}

Expand Down
2 changes: 1 addition & 1 deletion app/buck2_error/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#![feature(error_generic_member_access)]
#![feature(let_chains)]
#![feature(trait_alias)]
#![feature(trait_upcasting)]
#![cfg_attr(fbcode_build, feature(trait_upcasting))]

mod any;
pub mod classify;
Expand Down
4 changes: 2 additions & 2 deletions docs/getting_started.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ To get started, first install [rustup](https://rustup.rs/), then compile the
`buck2` executable:

```bash
rustup install nightly-2023-11-10
cargo +nightly-2023-11-10 install --git https://github.com/facebook/buck2.git buck2
rustup install nightly-2023-12-11
cargo +nightly-2023-12-11 install --git https://github.com/facebook/buck2.git buck2
```

The above commands install `buck2` into a suitable directory, such as
Expand Down
4 changes: 2 additions & 2 deletions rust-toolchain
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
# * NOTE: You may have to change this file in a follow up commit as ocamlrep
# has a dependency on buck2 git trunk.

# @rustc_version: rustc 1.75.0-nightly (0f44eb32f 2023-11-09)
channel = "nightly-2023-11-10"
# @rustc_version: rustc 1.76.0-nightly (d86d65bbc 2023-12-10)
channel = "nightly-2023-12-11"
components = ["llvm-tools-preview","rustc-dev","rust-src"]
1 change: 1 addition & 0 deletions starlark-rust/starlark/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@
// Features we use
#![allow(stable_features)]
#![allow(unknown_lints)] // for clippy::tuple_array_conversions
#![cfg_attr(rust_nightly, allow(internal_features))]
#![cfg_attr(rust_nightly, feature(const_type_id))]
#![cfg_attr(rust_nightly, feature(core_intrinsics))]
#![cfg_attr(rust_nightly, feature(cfg_sanitize))]
Expand Down
1 change: 1 addition & 0 deletions starlark-rust/starlark_map/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#![cfg_attr(rust_nightly, feature(core_intrinsics))]
#![cfg_attr(rust_nightly, feature(portable_simd))]
#![cfg_attr(rust_nightly, feature(cfg_version))]
#![cfg_attr(rust_nightly, allow(internal_features))]

mod hash_value;
mod hashed;
Expand Down

0 comments on commit 9bcdeb7

Please sign in to comment.