Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to save a Trial (SQA) with TTL seconds fails #382

Closed
chasewalden opened this issue Sep 9, 2020 · 1 comment
Closed

Trying to save a Trial (SQA) with TTL seconds fails #382

chasewalden opened this issue Sep 9, 2020 · 1 comment
Labels
fixready Fix has landed on master.

Comments

@chasewalden
Copy link

It seems the SQATrial definition may be broken. It looks like a copy-paste bug from the two lines above.

# pyre-fixme[8]: Attribute has type `Optional[int]`; used as `Column[bool]`.
ttl_seconds: Optional[int] = Column(Boolean)

Causes this issue when saving to SQL:

(builtins.ValueError) Value 10 is not None, True, or False
[SQL: INSERT INTO trial_v2 (abandoned_reason, deployed_name, experiment_id, \"index\", is_batched, num_arms_created, optimize_for_power, ttl_seconds, run_metadata, status, status_quo_name, time_completed, time_created, time_staged, time_run_started, trial_type, generation_step_index, properties) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)]\n[parameters: [{'run_metadata': {}, 'is_batched': False, 'ttl_seconds': 10, 'index': 0, 'status': <TrialStatus.CANDIDATE: 0>, 'properties': {}, 'generation_step_ind ... (160 characters truncated) ... ed': None, 'trial_type': None, 'time_completed': None, 'deployed_name': None, 'status_quo_name': None, 'time_staged': None, 'abandoned_reason': None}]]
@stevemandala stevemandala added the bug Something isn't working label Sep 10, 2020
@stevemandala
Copy link
Contributor

Thanks for catching this bug! bf15d40 should resolve this and is on master now. Should get included in the next release (which should be soon).

@stevemandala stevemandala added fixready Fix has landed on master. and removed bug Something isn't working labels Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixready Fix has landed on master.
Projects
None yet
Development

No branches or pull requests

2 participants