JSONPatch functionality

[manusa]

Description

Currently, we're leveraging Fabric8 outdated fork of https://github.com/flipkart-incubator/zjsonpatch.

The fork includes several commits ahead of the forked repository to remove dependencies (one of the principles in the Fabric8 Kubernetes Client is to keep dependencies to the minimum).
This comment provides additional details: #3489 (comment)

We need to find a proper replacement. we're not affected by security issues because our Jackson dependency is managed by the client project. However, eventually these dependencies might not be compatible any more.

Relates to:

• Critical CVE CVE-2017-7525 in zjsonpatch-0.3.0.jar #3489
• fix #3489: Migrated zjsonpatch from io.fabric8 to com.flipkart.zjsonpatch. Bumped version to 0.4.13 #4700

[stale]

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

[rohanKanojia]

I see this library being used in these places:

• kubernetes-client/junit/mockwebserver/src/main/java/io/fabric8/mockwebserver/crud/CrudDispatcher.java

  Line 114 in c70398e

  JsonNode updated = JsonPatch.apply(patch, source);

• kubernetes-client/junit/kubernetes-server-mock/src/main/java/io/fabric8/kubernetes/client/server/mock/crud/KubernetesCrudPersistence.java

  Lines 85 to 100 in c70398e

  	default void touchResourceVersion(JsonNode currentResource, JsonNode updatedResource) {
  	if (!JsonDiff.asJson(currentResource, updatedResource).isEmpty()) {
  	((ObjectNode) updatedResource.get(METADATA)).put(RESOURCE_VERSION, String.valueOf(requestResourceVersion()));
  	}
  	}
  	default void touchGeneration(JsonNode currentResource, JsonNode updatedResource) {
  	final JsonNode diff = JsonDiff.asJson(currentResource, updatedResource);
  	if (!diff.isEmpty() && shouldIncreaseGeneration(diff)) {
  	((ObjectNode) updatedResource.get(METADATA)).put(GENERATION,
  	currentResource.path(METADATA).path(GENERATION).asInt(0) + 1);
  	}
  	}
  	static boolean shouldIncreaseGeneration(JsonNode existing, JsonNode source) {
  	final JsonNode differences = Optional.ofNullable(existing).map(e -> JsonDiff.asJson(e, source))

• kubernetes-client/junit/kubernetes-server-mock/src/main/java/io/fabric8/kubernetes/client/server/mock/crud/PatchHandler.java

  Line 63 in c70398e

  fullPatch = JsonPatch.apply(patch, initPaths(currentResource.deepCopy(), patch));

• kubernetes-client/java-generator/it/src/main/java/io/fabric8/java/generator/testing/KubernetesResourceDiff.java

  Lines 55 to 59 in c70398e

  	JsonNode diff = JsonDiff.asJson(source1Json, source2Json);
  	List<JsonNode> aggregatedDiffs = StreamSupport.stream(diff.spliterator(), false).collect(Collectors.toList());
  	if (!aggregatedDiffs.isEmpty()) {
  	JsonNode generatedDiff = JsonPatch.apply(diff, source1Json);

• kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/PatchUtils.java

  Line 81 in c70398e

  .asJson(JsonDiff.asJson(withoutRuntimeState(current, omitStatus, serialization),

In these usages, I only see these two calls:

• JsonPatch.apply()
• JsonDiff.asJson()

Instead of relying on io.fabric8.zjsonpatch library can we implement/port these methods ?

[rohanKanojia]

flipkart-incubator/zjsonpatch Dependencies :

com.fasterxml.jackson.core:jackson-databind:2.14.0
com.fasterxml.jackson.core:jackson-databind:2.14.0
org.apache.commons:commons-collections4:4.4

fabric8io/zjsonpatch Dependencies:

com.fasterxml.jackson.core:jackson-databind:2.8.5
com.fasterxml.jackson.core:jackson-databind:2.8.5

Upstream fork is using commons-collections4 dependency to compute longest common subsequence among two JsonNodes while computing JsonDiff.asJson .

Fabric8 ZJsonPatch fork is using a ported version of Apache commons-collections4 's ListUtils class to avoid this dependency