Adds support for use of enum types as literals and nativeEnums #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabien0102
requested changes
Jul 29, 2021
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 98.49% 98.10% -0.40%
==========================================
Files 8 9 +1
Lines 332 369 +37
Branches 102 113 +11
==========================================
+ Hits 327 362 +35
- Misses 5 6 +1
- Partials 0 1 +1
Continue to review full report at Codecov.
|
anglinb
changed the title
|
I think I addressed all the feedback, thanks again for taking a look @fabien0102 🙇 |
fabien0102
approved these changes
Jul 29, 2021
fabien0102
pushed a commit
that referenced
this pull request
Jul 29, 2021
…40) * Checks in test documenting behavior * Implements enum import & declartion * Updates example to include enum * Updates tests to document expected case * Add handler for enum literals * Updates example * Addresses #38 (comment) * Addresses #38 (comment) * Addresses #40 (comment)
|
I wonder whether the following is a bug: export enum LoggerLevel { debug, info, warning, error, critical }
interface ILogger {
/**
* @default LoggerLevel.info
*/
level: LoggerLevel
}compiles down to export const loggerLevelSchema = z.nativeEnum(LoggerLevel);
const iLoggerSchema = z.object({
level: loggerLevelSchema.default("LoggerLevel.info"), //// <----- notice enum default is quoted
});TIA |
|
This looks like a bug, we didn’t think about this edge case. Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #39 and #35
Warnings⚠️
Relies on Adds support for native Typescript enums #38Rolled these together b/c Adds support for native Typescript enums #38 was a subset of this PR