Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward() doesn't support non-Variable inputs #246

Open
ezyang opened this issue Sep 27, 2017 · 1 comment
Open

forward() doesn't support non-Variable inputs #246

ezyang opened this issue Sep 27, 2017 · 1 comment

Comments

@ezyang
Copy link
Owner

ezyang commented Sep 27, 2017

I originally thought that no one would actually do this, but I was wrong! In bnlstm, https://github.com/pytorch/benchmark/blob/master/benchmarks/models/bnlstm.py an integer "time" is passed in to SeparatedBatchNorm1d, which is used to determine which running_mean and running_var is used.

If there are many other incidences of this, we may have to support this.

@jekbradbury
Copy link
Contributor

If the PyTorch API lets someone do something, they'll do it... but yeah recurrent batchnorm is the only situation I know of where you basically can't refactor such an auxiliary input out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants