Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrolled RNNs expose compiler performance problems #245

Open
ezyang opened this issue Sep 27, 2017 · 0 comments
Open

Unrolled RNNs expose compiler performance problems #245

ezyang opened this issue Sep 27, 2017 · 0 comments

Comments

@ezyang
Copy link
Owner

ezyang commented Sep 27, 2017

We should expect our users to try slapping torch.jit.compile on the top level of an RNN, which means that however long they unroll the RNN, the compiler is going to run on it. That means that, on real world RNNs, compiler performance may actually be a problem.

For example, I took bnlstm (https://github.com/pytorch/benchmark/blob/master/benchmarks/bnlstm.py) and ran compile on the top-level model. Because bnlstm was fed pixel-by-pixel the MNIST data set, it has 784 hidden layers. It took 17s to compile the trace (and this is a conservative guess, because for other reasons compilation failed midway through.)

We don't necessarily have to fix this, but this will be something important to communicate to users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant