Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth over some pybind11 integration issues / document common patterns #218

Open
ezyang opened this issue Sep 11, 2017 · 2 comments
Open

Comments

@ezyang
Copy link
Owner

ezyang commented Sep 11, 2017

Code that uses pybind11 often has to interoperate with legacy code that uses THPObjectPtr. Thus, there are a number of common things that one might have to do, e.g., interconvert between PyObject*, THPObjectPtr, py::handle and py::object. We should document pave the cowpaths, and eventually get rid of THPObjectPtr entirely (if possible.)

@apaszke
Copy link
Collaborator

apaszke commented Sep 12, 2017

Let's not go too far too quickly. We still haven't fully evaluated pybind. While the quality of bindings doesn't really matter for the JIT, because it's not a hot spot, we need to maintain the lowest possible overhead for tensor/autograd bindings.

@ezyang
Copy link
Owner Author

ezyang commented Sep 20, 2017

Here's a start: https://fb.quip.com/bX0RA1N2Xng2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants