From 9ce9f870effef6884b88ae4a563a7f1659f2c029 Mon Sep 17 00:00:00 2001
From: Bernd Gollesch <gollesch@ait.co.at>
Date: Wed, 6 Jul 2016 15:07:09 +0200
Subject: [PATCH] Added consistency check for what to post to EDDN compared to
 what the station should offer.

---
 plugins/edapi_plug.py | 46 +++++++++++++++++++++++++++++++++++++++----
 1 file changed, 42 insertions(+), 4 deletions(-)

diff --git a/plugins/edapi_plug.py b/plugins/edapi_plug.py
index d9c12bd6..ad6579a0 100644
--- a/plugins/edapi_plug.py
+++ b/plugins/edapi_plug.py
@@ -525,8 +525,11 @@ def run(self):
                     "Station"
                 )
                 tdenv.NOTE("{} updated.", csvPath)
-                station_lookup = tdb.lookupPlace(place)
             station_lookup = tdb.lookupStation(station, system)
+            if not station_lookup:
+                raise plugins.PluginException(
+                    "Something went wrong while adding the station to the DB."
+                )
         else:
             # See if we need to update the info for this station.
             print('Station known.')
@@ -774,7 +777,42 @@ def commodity_int(key):
             )
             con._debug = False
 
-            if len(eddn_market):
+            def consistencyCheck(checkName, checkList):
+                warnList = [
+                    "The station should{s} have a {what}, but the API did{d} return one.",
+                    "If you think the DB entry is wrong you can correct it by running:",
+                    "   trade.py station -u --{what} {yn} '@{sys}/{stn}'",
+                ]
+                warnParameter = [
+                    ("n't", "", "Y"),
+                    ("", "n't", "N"),
+                ]
+                warnResult  = False
+                checkResult = True
+
+                checkAttribute = getattr(station_lookup, checkName)
+                if len(checkList) > 0:
+                    if checkAttribute == "N":
+                        warnResult  = True
+                        checkResult = False
+                        s, d, yn = warnParameter[0]
+                        warnList.append("Ignoring {what}.")
+                else:
+                    checkResult = False
+                    if checkAttribute == "Y":
+                        warnResult  = True
+                        s, d, yn = warnParameter[1]
+
+                if warnResult:
+                    for warnText in warnList:
+                        tdenv.WARN(
+                        warnText,
+                        what=checkName, sys=system, stn=station,
+                        s=s, d=d, yn=yn
+                    )
+                return checkResult
+
+            if consistencyCheck("market", eddn_market):
                 print('Posting commodities to EDDN...')
                 con.publishCommodities(
                     system,
@@ -782,7 +820,7 @@ def commodity_int(key):
                     eddn_market
                 )
 
-            if len(yardList):
+            if consistencyCheck("shipyard", yardList):
                 print('Posting shipyard to EDDN...')
                 con.publishShipyard(
                     system,
@@ -802,7 +840,7 @@ def commodity_int(key):
                             ('bobble', 'decal', 'paintjob')
                         ):
                             tdenv.NOTE("Unknown module ID: {}, name: {}", module['id'], module['name'])
-                if len(eddn_modules):
+                if consistencyCheck("outfitting", eddn_modules):
                     print('Posting outfitting to EDDN...')
                     con.publishOutfitting(
                         system,