Fix polyline and polygon points parsing #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling of numbers in scientific notation in `parsePoints` used to be incorrect, because a number could be broken by an exponent minus sign, resulting in incorrect values. E.g. '2.5e-1' -> '2.5e', '-1'.
amarunko
approved these changes
May 12, 2020
ystrot
approved these changes
May 14, 2020
|
Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling of numbers in scientific notation in
parsePointsused to beincorrect, because a number could be broken by an exponent minus sign,
resulting in incorrect values.
E.g. '2.5e-1' -> '2.5e', '-1'.
String-splitting-based parsing is replaced with a simpler use of
Scanner, otherwise keeping the behaviour, esp. error handling, unchanged.