Add correct zoom-scroll handling #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Source/animation/types/animation_generators/CombinationAnimationGenerator.swift
ystrot
reviewed
Apr 16, 2020
amarunko
reviewed
Apr 16, 2020
| @@ -8,7 +8,7 @@ import AppKit | |||
|
|
|||
| class AnimationUtils { | |||
|
|
|||
| class func layerForNodeRenderer(_ renderer: NodeRenderer, _ context: AnimationContext, animation: Animation, customBounds: Rect? = .none, shouldRenderContent: Bool = true) -> ShapeLayer { | |||
| class func layerForNodeRenderer(_ renderer: NodeRenderer, animation: Animation, customBounds: Rect? = .none, shouldRenderContent: Bool = true) -> ShapeLayer { | |||
There was a problem hiding this comment.
Maybe we should try to use maximum line length equal to 120 symbols (for example)? Long lines are really uncomfortable to read and understand, especially here on Github.
There was a problem hiding this comment.
Would be great to add it to our SwiftLint 😉
There was a problem hiding this comment.
If you agree - it takes about 5 mines to update rules for SwiftLint and maybe some time to format current issues.
ystrot
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.