Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing initializer 'init(frame:)' in SVGView makes it unusable with IBDesignable #435

Closed
edmundmaruhn opened this issue Jun 25, 2018 · 3 comments
Assignees
Milestone

Comments

@edmundmaruhn
Copy link

Unfortunately the SVGView class lacks of an initializer that is invoked behind the scenes by Xcode when applying IBDesignable marked components. This lets the IBDesignablesAgentCocoaTouch agent crash and views do not render properly and breaking that awesome Xcode feature at all.

Please can you add the missing initializer to SVGView?

@ystrot ystrot closed this as completed in 54d6441 Jun 26, 2018
@ystrot ystrot self-assigned this Jun 26, 2018
@ystrot ystrot added this to the 0.9.2 milestone Jun 26, 2018
@ystrot
Copy link
Member

ystrot commented Jun 26, 2018

Fixed in the master branch and will be part of the upcoming 0.9.2 release.

@mrgrauel
Copy link

mrgrauel commented Jul 3, 2018

This causes that SVGView.init(frame: .zero) is an ambigious call cause the methode init(node: frame:) has an default value for node. To fix this we have to remove the default value for the node. Do you agree?

@ystrot
Copy link
Member

ystrot commented Jul 9, 2018

@mrgrauel looks like you're right. Sad we already released 0.9.2, but fixed this in the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants