Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG incorrect stroke/fill color parsing #169

Closed
kayuri opened this issue Sep 28, 2017 · 1 comment
Closed

SVG incorrect stroke/fill color parsing #169

kayuri opened this issue Sep 28, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@kayuri
Copy link
Collaborator

kayuri commented Sep 28, 2017

Some colors are not parsed/serialized correctly, e.g. lime:

Sample SVG:

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1">
  <circle r="80" cx="240" cy="150" fill="blue"/>
  <rect width="200" height="160" x="140" y="70" fill="red !important"/>
  <rect width="200" height="160" x="140" y="70" fill="none" stroke="lime" stroke-width="4"/>
</svg>

Serialized into:

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1">
  <circle r="80" cy="150" cx="240" fill="blue"/>
  <rect height="160" x="140" y="70" width="200" fill="black"/>
  <rect height="160" x="140" y="70" width="200" fill="none" stroke="black" stroke-width="4.0"/>
</svg>
@kayuri kayuri added the bug label Sep 28, 2017
@kayuri kayuri self-assigned this Sep 28, 2017
@f3dm76 f3dm76 added this to the 0.9.2 milestone Jun 22, 2018
@f3dm76
Copy link
Collaborator

f3dm76 commented Jun 22, 2018

On master version, serialized into:

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1"  ><g>
<circle  r="80" cy="150" cx="240"  fill="blue"/>
<rect  height="160" x="140" y="70" width="200"  fill="red"/>
<rect  height="160" x="140" y="70" width="200"  fill="none" stroke="lime" stroke-width="4.0"/></g></svg>

@ystrot ystrot closed this as completed Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants