Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacawView never gets deinited #109

Closed
deathByLiche opened this issue Mar 20, 2017 · 3 comments
Closed

MacawView never gets deinited #109

deathByLiche opened this issue Mar 20, 2017 · 3 comments
Assignees
Milestone

Comments

@deathByLiche
Copy link

It seems that any MacawView that gets instantiated, never gets released, even if it is removed from the view hierarchy and set to nil.

I believe that the RenderContext and NodesMap are holding strong references to the view, as well as maybe the AnimationCache.

@vhailor13
Copy link
Contributor

Hello @deathByLiche ,
Thanks for reporting this issue. Fixed in latest master commits:
7e8d619
7966950

@deathByLiche
Copy link
Author

Thanks for the quick fix!

As I was poking around more yesterday, it also looks like Macaw never releases some of it resources. Every time you use SVGParser to parse an svg, it increases the memory footprint, which never seems to go away. I even tried parsing an svg and immediately throwing away the returned node and it still increased the apps memory.

@vhailor13
Copy link
Contributor

@deathByLiche Just fixed nasty leak 32a5b21 Now nodes should be released properly. Thanks for report!

@vhailor13 vhailor13 added this to the 0.8.2 milestone Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants