Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow composition in QReaders #45

Open
audetto opened this issue Mar 2, 2017 · 0 comments
Open

Allow composition in QReaders #45

audetto opened this issue Mar 2, 2017 · 0 comments

Comments

@audetto
Copy link

audetto commented Mar 2, 2017

Hi,
I once open an issue about Strings in qPyton that are returned ad bytes and not unicode strings in python 3.
#35

The issue was closed after some improvement to the QReader were implemented.

I think there is still room for improvement as even with the current code I struggle to have override the behaviour.
The problem is that I want to use PandasQReader.

Now, PandasQReader inherits from QReader, so I cant really inject my class in between, I would have to copy PandasQReader so it inherits from my class.

This is similar to the stream framework in Java. There each stream class introduces some new behaviour and the way to make them work together is by putting one inside the other, rather than make them inherit from a particular one.

So if PandasQReader took a QReader in the constructor I could pass at runtime my modified class as opposed to the default one.

Unless I have missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant