-
-
Notifications
You must be signed in to change notification settings - Fork 21.7k
Remove history.md from being packaged on publish #6780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
shivarm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree!
UlisesGascon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach... and probably we want to do it in other packages too.
Also this is potentially related to expressjs/discussions#293
|
@UlisesGascon I did not even remember that issue from last year - but deifnitely |
|
@expressjs/express-tc for review |
wesleytodd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove History.md file from being published.
This would reduce the size of the package by ~ 56% (loosing 29851 kb) and for 48M downloads/weeks this would save ~1.4 Tb of transfer per week. (unzip)
This PR completely remove this document from the tarball published but we could also
I would recommend to drop the file completely and let people reading it on github