Skip to content

Conversation

@sheplu
Copy link
Member

@sheplu sheplu commented Sep 22, 2025

Remove History.md file from being published.

This would reduce the size of the package by ~ 56% (loosing 29851 kb) and for 48M downloads/weeks this would save ~1.4 Tb of transfer per week. (unzip)

  • previous gzip: 52,415 kb
  • new gzip: 22,564 kb
  • previous unzip: 221 kb
  • new unzip: 98 kb

This PR completely remove this document from the tarball published but we could also

  • keep the document and dynamically add the link to the history.md file in the repo
  • only keep the content of the latest release (and maybe with a link)

I would recommend to drop the file completely and let people reading it on github

Copy link
Contributor

@shivarm shivarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree!

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach... and probably we want to do it in other packages too.

Also this is potentially related to expressjs/discussions#293

@sheplu
Copy link
Member Author

sheplu commented Sep 22, 2025

@UlisesGascon I did not even remember that issue from last year - but deifnitely
I opened just this PR to have the discussion about removing it from package, keep it with a link , keep it with only the latest release but when done I will open the PR on all packages to have something equivalent :)

@sheplu
Copy link
Member Author

sheplu commented Sep 22, 2025

@expressjs/express-tc for review

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sheplu sheplu merged commit 9a7afb2 into master Sep 25, 2025
26 checks passed
@sheplu sheplu deleted the remove-history-on-publish branch September 25, 2025 05:20
@UlisesGascon UlisesGascon mentioned this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants