Skip to content

Refactor req.is for cleaner argument handling #6101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor req.is for cleaner argument handling #6101

wants to merge 3 commits into from

Conversation

@Ayoub-Mabrouk
Copy link
Contributor

@Ayoub-Mabrouk Ayoub-Mabrouk commented Oct 29, 2024 •
edited by UlisesGascon
Loading

  • Simplified the logic for accepting both array and flattened arguments.
  • Used Array.from for improved readability and conciseness.

Related: #6093

@Ayoub-Mabrouk
Refactor req.is for cleaner argument handling
61434d0 
- Simplified the logic for accepting both array and flattened arguments.
- Used Array.from for improved readability and conciseness.
@Ayoub-Mabrouk
Refactor req.is for cleaner argument handling
83b6642 
- Simplified the logic for accepting both array and flattened arguments.
- Used Array.from for improved readability and conciseness.

refactor: simplify req.is implementation while preserving support for multiple types

- Refactored to use Array.isArray and Array.from for cleaner syntax.
- Maintained existing support for both array and argument inputs.
- Updated JSDoc to reflect the use of `(String|Array)` for types parameter.
@Ayoub-Mabrouk
Merge branch 'chore/req-is-argument-handling' of https://github.com/A…
daadd3f 
…youb-Mabrouk/express into chore/req-is-argument-handling
wesleytodd
wesleytodd requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a fine improvement using the new api but I think we would be better off lining up a breaking change for v6 to make this a non-variadic api. IMO we should not make this change and remove all of this in the future.

@UlisesGascon UlisesGascon added 6.x and removed 5.x labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleytodd wesleytodd wesleytodd requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

6.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ayoub-Mabrouk @wesleytodd @UlisesGascon