Skip to content

Commit c980c10

Browse files
Tom Cheungtsapeta
Tom Cheung
authored andcommitted
Fix image cannot show in iOS 14 (facebook#29420)
Summary: This PR is to fix facebook#29279, which image cannot show in iOS 14 As facebook#29279 (comment) mention, this issue can be fixed by calling ` [super displayLayer:layer];` it it is still image, to let `UIImageView` handle still image rendering ## Changelog [iOS] [Fixed] - Fix image cannot show in iOS 14 Pull Request resolved: facebook#29420 Test Plan: Image can be shown in iOS 14 build with Xcode 12 beta, using ```js <Image source={require('./images/some_local_image.jpg')}/> ``` It may also need to test gif image is render correctly ```js <Image source={{uri: 'https://some_remote_gif_image.gif'}}/> ``` Reviewed By: p-sun Differential Revision: D22619448 Pulled By: shergin fbshipit-source-id: f4d0ad83af945a6b8099d4eaea5a5f1933c7bfd2
1 parent 3f068be commit c980c10

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Libraries/Image/RCTUIImageViewAnimated.m

+2
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,8 @@ - (void)displayLayer:(CALayer *)layer
278278
if (_currentFrame) {
279279
layer.contentsScale = self.animatedImageScale;
280280
layer.contents = (__bridge id)_currentFrame.CGImage;
281+
} else {
282+
[super displayLayer:layer];
281283
}
282284
}
283285

0 commit comments

Comments
 (0)