Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Missing withUnimodules #4701

Closed
axelekwall opened this issue May 4, 2023 · 5 comments · Fixed by expo/examples#435
Closed

Missing withUnimodules #4701

axelekwall opened this issue May 4, 2023 · 5 comments · Fixed by expo/examples#435
Labels
needs review Issue is ready to be reviewed by a maintainer

Comments

@axelekwall
Copy link

Summary

The recent update to the @expo/webpack-config package with the removal of the withUnimodules function has broken the expo storybook example implementation for the web. The function is still mentioned in the README and in the with-storybook example here.

Related issue in expo/examples repo: expo/examples#422

Environment

N/A

Please specify your device/emulator/simulator platform, model and version

N/A

Error output

ERR! TypeError: withUnimodules is not a function
ERR!     at module.exports (~/expo-examples/with-storybook/.storybook/webpack.config.js:5:10)

Reproducible demo or steps to reproduce from a blank project

  1. Follow the with-storybook expo example instructions for web.
  2. Get error when trying to run the example.
@axelekwall axelekwall added the needs review Issue is ready to be reviewed by a maintainer label May 4, 2023
@brandon-gs
Copy link

Any update here?

@jaronoff97
Copy link

also looking for updates 😭

@schlosser
Copy link

Also running into this!

@axelekwall
Copy link
Author

Unfortunately I don't have any updates on this. We decided to not follow through with our Storybook setup and I haven't looked more into this since.

@EvanBacon
Copy link
Contributor

withUnimodules was a bit of a misleading name since unimodules were a native feature and the function configured Webpack to load react-native-web + modules maintained by the Expo team. In many ways a better name would be withMetroFeatures. Regardless, it seemed that this was mostly used for Storybook and the Storybook team has a more official solution now. I've updated the example accordingly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs review Issue is ready to be reviewed by a maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants