Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to babel-preset-react-native and remove jest-preset-expo when ejecting to plain React Native project #243

Closed
brentvatne opened this issue Jun 6, 2017 · 3 comments
Assignees

Comments

@brentvatne
Copy link
Member

brentvatne commented Jun 6, 2017

Related to:

When you eject to a plain React Native project, we install "babel-preset-react-native" and change the preset used in .babelrc to "react-native".

@brentvatne brentvatne changed the title Switch to babel-preset-react-native-stage-0 when ejecting to plain React Native project Switch to babel-preset-react-native when ejecting to plain React Native project Jun 6, 2017
@fson
Copy link
Contributor

fson commented Jul 25, 2017

The template .babelrc file uses babel-preset-expo, which extends babel-preset-react-native by adding decorator support. I think this makes it possible to use decorators in CRNA apps. If we replace the "expo" preset with "react-native", wouldn't it break any app that relies on the decorator support?

@brentvatne
Copy link
Member Author

@fson - good point, we should use babel-preset-react-native-stage-0/decorator-support (this is the same preset that babel-preset-expo extends)

@brentvatne brentvatne changed the title Switch to babel-preset-react-native when ejecting to plain React Native project Switch to babel-preset-react-native and remove jest-preset-expo when ejecting to plain React Native project Jan 19, 2018
@fson
Copy link
Contributor

fson commented Jan 24, 2018

This was added in #328.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants