Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Killboard Streams #932

Closed
CalMatar opened this issue Mar 24, 2020 · 6 comments
Closed

Killboard Streams #932

CalMatar opened this issue Mar 24, 2020 · 6 comments
Assignees
Milestone

Comments

@CalMatar
Copy link

Found a new issues with the Release Client.
The new Killboard Streams system does not seam to be working the way I believe it is supposed to work. First off, I want to make sure that I have the workings correct. When you go to the filter and select the individual system that you are in it will show that KB. If you select the MAP that you are on it will show ALL KBs for ALL of the systems that are shown on THAT MAP. I did click on the ALL OF NEW EDEN one and I do not recommend that one on the public server as it just starts pulling them and the list gets long quick. The problem is the one for the Map one does not work. See the below screen shots.
This is what I see for my home system.
Killboard Home System
This is what I have selected.
Killboard Streams Selection
I go into my connected C5 and this is what I see.
Killboard C5
Still the same thing selected.
Killboard Streams Selection1
This is acting as if I only had the individual system selected not the map one.

Hope this helps.

@exodus4d
Copy link
Owner

Thanks, you are right. I found the issue and will fix it before the final release.

Yeah, this is how it should work. From a technical perspective, each client always subscribes to the full "killstream" of all killmails in all systems, and PF then "filters" out non-relevant KMs (based on the checkboxes).
I had the idea, clients could "pre-cache" killmails that are not relevant yet, but might be relevant a second later, e.g. if someone adds a system to map, where killmails were received shortly.... (CCPs static ESI API endpoint for KM´s , would not list them because it has some minutes delay).... But this was not practicable, because you can not predict what systems might be added in future, and caching all KMs (even for a sort time) could be lot of data.

@exodus4d
Copy link
Owner

This should now be fixed on the public server. - To see this, please clear browser cache.

@exodus4d exodus4d self-assigned this Mar 25, 2020
@exodus4d exodus4d added this to the v2.0.0 milestone Mar 25, 2020
@CalMatar
Copy link
Author

I just checked and this is what I see after clearing cache and also closing and reopening the browser window to make sure since it did not fix it the first time.
Main WH:
Killboard Streams Error
Attached WH:
Killboard Streams Error1
I am using Firefox and the way that you said to clear the cache does not work for me but I cleared it the way I know how. I also refreshed the browser and then closed it and opened it again. I even tried opening up a completely separate browser window and just opened Pathfinder and got the same results.

@exodus4d
Copy link
Owner

Ah okay, I guess you have got me wrong. I´ll try to make it more clear what to expect from the killstrem:

  1. Add "Jita" and "Amarr" to map.
  2. Set killboard filter to just "map" (you have done this already)
  3. Select "Amarr", you should see the last 5 kills in Amarr (no kills from any other system)
  4. Wait some minutes.....

As soon as there is a new KM received from zKillboards "WebSocket" API, you will see it above the "historic" Amarr KMs. (there is a new "divider" added):

kb_filter2

There is no way to request killmails from more then one system. So we can not show "historic" KMs from all mapped systems, if you do not bomb ESI with one request for each mapped system.

@CalMatar
Copy link
Author

Ok, so if you have MAP selected the only way to get KMs from all the connected maps is if they happen after you map to them before the KMs happen? You can see the historic when you link to them and see the system itself no matter what but to see them on the MAP you only will get the new ones.
Do I understand that correctly?

@exodus4d
Copy link
Owner

exodus4d commented Apr 6, 2020

Yes that is correct.
From technical perspective there is no way to get "historic" killmails for multiple systems in a single API call (neither ESI nor zKillboard).

But there is still a bug which I haven´t fixed yet: If you select a system that does not have any "historic" Kills, and MAP is selected. You don´t see new killmails :( - That is easy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants