Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty system shows the box where character should be [1.5.2] #823

Closed
mrurb opened this issue Jul 23, 2019 · 5 comments
Closed

Empty system shows the box where character should be [1.5.2] #823

mrurb opened this issue Jul 23, 2019 · 5 comments
Assignees
Milestone

Comments

@mrurb
Copy link

mrurb commented Jul 23, 2019

There is currently no one in this system and pathfinder is showing that fine, but the extra part is still showing under.
image

and when holding the mouse over the system to show everyone in that system it looks like this
image

Testing done on the public pathfinder, i've not found the exact way to reproduce this yet.

I did some further testing and it seems that if you are the last one to leave a system this problem is always there, in the case underneath i just moved a char from the C6 to the C5 and the only char tracked by this map is the char you can see on the map.
image

@mrurb
Copy link
Author

mrurb commented Jul 23, 2019

It seems like that after the quick fix in #822 it now does not decrease the count of people in the system your leaving, after a bit of jumping around i got my map to look like this:
image

From what i can see, it never actually counts down when a person leaves the system.

@exodus4d
Copy link
Owner

@mrurb Thanks! try the updated file once more, please. I missed something in the hurry

@mrurb
Copy link
Author

mrurb commented Jul 23, 2019

@exodus4d tried the new map.php file and the problem does not seem to be fixed

@Meganitrospeed
Copy link

Can confirm, its not fixed, we are experiencing the same issue

@exodus4d
Copy link
Owner

@mrurb Thanks for your comprehensive testing and reporting! This is fixed with 3e269bd.

Bug description:

To speed up client side map updates with new active characters data in a systems, unique string hashes, build from current active characters+ships, are compared with hashes build from new active characters data.
The hash() function was changed to build integer hashes, rather than strings...
3e269bd#diff-630f9aae23d2da6473a482c15e3f6246L228
... this results in an error because e.g 45635.length is undefined...
3e269bd#diff-630f9aae23d2da6473a482c15e3f6246L315
... so system body becomes cleared but not collapsed.

There will be a new Hotfix release v1.5.3 available, today

@exodus4d exodus4d added this to the v1.5.3 milestone Jul 27, 2019
@exodus4d exodus4d self-assigned this Jul 27, 2019
@exodus4d exodus4d mentioned this issue Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants