Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting a 500 after update to 1.5.1 #783

Closed
der-micky opened this issue May 16, 2019 · 1 comment
Closed

getting a 500 after update to 1.5.1 #783

der-micky opened this issue May 16, 2019 · 1 comment
Assignees
Milestone

Comments

@der-micky
Copy link

der-micky commented May 16, 2019

Log shows something like:

2019/05/16 15:13:39 [error] 22332#22332: *1517 FastCGI sent in stderr: "PHP message: Declaration of Model\Pathfinder\MapModel::newLog($action = ''): lib\logging\LogInterface should be compatible with Model\AbstractModel::newLog(string $action = ''): lib\logging\LogInterface

I corrected it by commenting out the type declaration in .../main/model/abstractmodel.php

with 500 error:
protected function newLog( string $action = '' ) : Logging\LogInterface{

my workaround:
protected function newLog( /*string*/ $action = '' ) : Logging\LogInterface{

Not sure if that's the intended solution but it did the trick for me :)
Thx,

-Micky

@exodus4d
Copy link
Owner

exodus4d commented Jun 2, 2019

Thanks for reporting! I haven´t seen the error on my installations so far.
I fixed it with adding the missing string type instead of removing it ;)

@exodus4d exodus4d added this to the v1.5.2 milestone Jun 2, 2019
@exodus4d exodus4d self-assigned this Jun 2, 2019
@exodus4d exodus4d mentioned this issue Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants