Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB hostnames cannot contain hyphens or underscores #780

Closed
ori-sky opened this issue May 11, 2019 · 1 comment
Closed

DB hostnames cannot contain hyphens or underscores #780

ori-sky opened this issue May 11, 2019 · 1 comment
Assignees
Milestone

Comments

@ori-sky
Copy link

ori-sky commented May 11, 2019

After updating to v1.5.1, DB hostnames can no longer contain hyphens or underscores in them, even though these are valid hostname characters.

For example, setting the host for DB_PF_DNS to "mariadb-pathfinder" results in it being parsed as "mariadb", which is wrong.

@exodus4d
Copy link
Owner

@shockkolate Thanks for reporting. I had to update the Regex for parsing the DNS string. Ill fix this soon!
I updated the Regex test for the new Regex with your example:
https://regex101.com/r/VWml7X/3

@exodus4d exodus4d self-assigned this May 11, 2019
@exodus4d exodus4d added this to the v1.5.2 milestone May 11, 2019
@exodus4d exodus4d mentioned this issue Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants