-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package exo as installable #354
Conversation
For reference, since we talked on X. Here are the issues I encountered:
|
Still getting this error:
|
exo/main.py
Outdated
@@ -25,6 +28,8 @@ | |||
from exo.orchestration.node import Node | |||
from exo.models import model_base_shards | |||
from exo.viz.topology_viz import TopologyViz | |||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, but this should go up near the other non-exo imports
exo/main.py
Outdated
def open_web_chat(): | ||
if web_chat_urls: | ||
import subprocess | ||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already imported at the top and i think subprocess should be too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i have made changes addressing both suggestions. thanks @dtnewman !!
implementation uses nuitka to compile python to C and create an executable.