Skip to content

Commit 1edd066

Browse files
committed
rm redundant cleanup task
1 parent c557f21 commit 1edd066

File tree

2 files changed

+2
-17
lines changed

2 files changed

+2
-17
lines changed

exo/networking/manual/manual_discovery.py

-16
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ def __init__(
2222
self.create_peer_handle = create_peer_handle
2323

2424
self.listen_task = None
25-
self.cleanup_task = None
2625
self.known_peers: Dict[str, PeerHandle] = {}
2726

2827
self._cached_peers: Dict[str, PeerConfig] = {}
@@ -32,11 +31,9 @@ def __init__(
3231

3332
async def start(self) -> None:
3433
self.listen_task = asyncio.create_task(self.task_find_peers_from_config())
35-
self.cleanup_task = asyncio.create_task(self.task_clean_up_peers_from_config())
3634

3735
async def stop(self) -> None:
3836
if self.listen_task: self.listen_task.cancel()
39-
if self.cleanup_task: self.cleanup_task.cancel()
4037
self._file_executor.shutdown(wait=True)
4138

4239
async def discover_peers(self, wait_for_peers: int = 0) -> List[PeerHandle]:
@@ -71,19 +68,6 @@ async def task_find_peers_from_config(self):
7168

7269
if DEBUG_DISCOVERY >= 2: print(f"Current known peers: {[peer.id() for peer in self.known_peers.values()]}")
7370

74-
async def task_clean_up_peers_from_config(self):
75-
if DEBUG_DISCOVERY >= 2: print("Starting task to clean up peers from config...")
76-
while True:
77-
peers_from_config = await self._get_peers()
78-
if peers_from_config:
79-
peers_to_remove = [peer for peer in self.known_peers.keys() if peer not in peers_from_config]
80-
81-
for peer in peers_to_remove:
82-
if DEBUG_DISCOVERY >= 2: print(f"{peer} is no longer found in the config but is currently a known peer. Removing from known peers...")
83-
self.known_peers.pop(peer, None)
84-
85-
await asyncio.sleep(1.0)
86-
8771
async def _get_peers(self):
8872
try:
8973
async with self._lock:

exo/networking/manual/test_manual_discovery.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,8 @@ async def test_dynamic_config_update(self):
156156
await asyncio.sleep(1.5)
157157

158158
updated_peers = await self.discovery1.discover_peers(wait_for_peers=1)
159-
self.assertEqual(len(updated_peers), 1)
159+
# NOTE: stale peers will be cleaned up by StandardNode
160+
self.assertEqual(len(updated_peers), 2)
160161

161162

162163
if __name__ == "__main__":

0 commit comments

Comments
 (0)