Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seems to be an error on line 21 of exiftool.rb #11

Closed
unbewusst opened this issue Nov 11, 2017 · 2 comments
Closed

seems to be an error on line 21 of exiftool.rb #11

unbewusst opened this issue Nov 11, 2017 · 2 comments

Comments

@unbewusst
Copy link

I had to change line 21 to
exiftool_version.to_f > 0.0

because as steated on line 24

This is a string, not a float, to handle versions like "9.40" properly.

also I'm planning to add functionnality to write GPS datas...

@unbewusst
Copy link
Author

first mokeup of my addon #setGPS
class Exiftool
def self.setGPS file, gps
exiftool_opts = ""
gps.each do |field, value|
exiftool_opts << "'-EXIF:#{field}=#{value}' "
end
cmd = "#{self.command} #{exiftool_opts} #{Shellwords.escape file.to_s} 2> /dev/null"
#puts "cmd = '#{cmd}'"
return #{cmd}.strip.gsub(/^(\d+).*/, '\1').to_i == 1
end
end

I'll arrange, as u, to set several files instead of only one...

@unbewusst
Copy link
Author

the backticks are laking because of pasting I mean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant