Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update introduction.md in International Calling Connoisseur #2917

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update introduction.md in International Calling Connoisseur #2917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exercises/concept/international-calling-connoisseur/.docs/introduction.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ The [size][map-size-javadoc] method returns the number of entries.
fruitPrices.size(); // Returns 2
```

You can use the [keys] or [values] methods to obtain the keys or the values in a Map as a Set or collection respectively.studentScores
You can use the [keys] or [values] methods to obtain the keys or the values in a Map as a Set or collection respectively.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed there are other issues here:

  • The [keys] and [values] are supposed to be links, but they are missing the URLs.
  • Even then, [keys] should be [keySet].

To make it easier, I've tried adding suggestions where I can:

Suggested change
You can use the [keys] or [values] methods to obtain the keys or the values in a Map as a Set or collection respectively.
You can use the [keySet][map-keyset-javadoc] or [values][map-values-javadoc] methods to obtain the keys or the values in a Map as a Set or collection respectively.

Will also need to add the following lines to the bottom of this file (I can't add seem to add these as suggestions):

map-keyset-javadoc: https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/Map.html#keySet()
map-values-javadoc: https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/Map.html#values()

Could you also please check the following files for the same problem:


```java
fruitPrices.keys(); // Returns "apple" and "pear" in a set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the other comment, should be keySet

Suggested change
fruitPrices.keys(); // Returns "apple" and "pear" in a set
fruitPrices.keySet(); // Returns "apple" and "pear" in a set

Could you also please check the following files for the same problem:

Expand Down