Update introduction.md in International Calling Connoisseur #2917
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed "studentScores", which seems to be there by mistake.
kadrisamuel
changed the title
kahgoh
reviewed
Feb 26, 2025
| @@ -56,7 +56,7 @@ The [size][map-size-javadoc] method returns the number of entries. | |||
| fruitPrices.size(); // Returns 2 | |||
| ``` | |||
|
|
|||
| You can use the [keys] or [values] methods to obtain the keys or the values in a Map as a Set or collection respectively.studentScores | |||
| You can use the [keys] or [values] methods to obtain the keys or the values in a Map as a Set or collection respectively. | |||
|
|
|||
| ```java | |||
| fruitPrices.keys(); // Returns "apple" and "pear" in a set | |||
There was a problem hiding this comment.
As mentioned in the other comment, should be keySet
Suggested change
| fruitPrices.keys(); // Returns "apple" and "pear" in a set | |
| fruitPrices.keySet(); // Returns "apple" and "pear" in a set |
Could you also please check the following files for the same problem:
| @@ -56,7 +56,7 @@ The [size][map-size-javadoc] method returns the number of entries. | |||
| fruitPrices.size(); // Returns 2 | |||
| ``` | |||
|
|
|||
| You can use the [keys] or [values] methods to obtain the keys or the values in a Map as a Set or collection respectively.studentScores | |||
| You can use the [keys] or [values] methods to obtain the keys or the values in a Map as a Set or collection respectively. | |||
There was a problem hiding this comment.
I noticed there are other issues here:
- The
[keys]and[values]are supposed to be links, but they are missing the URLs. - Even then,
[keys]should be[keySet].
To make it easier, I've tried adding suggestions where I can:
Suggested change
| You can use the [keys] or [values] methods to obtain the keys or the values in a Map as a Set or collection respectively. | |
| You can use the [keySet][map-keyset-javadoc] or [values][map-values-javadoc] methods to obtain the keys or the values in a Map as a Set or collection respectively. |
Will also need to add the following lines to the bottom of this file (I can't add seem to add these as suggestions):
map-keyset-javadoc: https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/Map.html#keySet()
map-values-javadoc: https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/Map.html#values()
Could you also please check the following files for the same problem:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed "studentScores", which seems to be there by mistake.
pull request
Reviewer Resources:
Track Policies