From 0e4eefe5a0a6d612aef889b284e465c5fd1b32d5 Mon Sep 17 00:00:00 2001 From: Alex Zamai Date: Fri, 22 Mar 2024 12:34:59 +0800 Subject: [PATCH] prime-factors: use slices package to sort and compare test cases --- .../prime-factors/prime_factors_test.go | 28 +++---------------- 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/exercises/practice/prime-factors/prime_factors_test.go b/exercises/practice/prime-factors/prime_factors_test.go index 40a0ba4a4..239ababdb 100644 --- a/exercises/practice/prime-factors/prime_factors_test.go +++ b/exercises/practice/prime-factors/prime_factors_test.go @@ -1,7 +1,7 @@ package prime import ( - "sort" + "slices" "testing" ) @@ -9,9 +9,9 @@ func TestPrimeFactors(t *testing.T) { for _, tc := range testCases { t.Run(tc.description, func(t *testing.T) { actual := Factors(tc.input) - sort.Slice(actual, ascending(actual)) - sort.Slice(tc.expected, ascending(tc.expected)) - if !slicesEqual(actual, tc.expected) { + slices.Sort(actual) + slices.Sort(tc.expected) + if !slices.Equal(actual, tc.expected) { t.Fatalf("Factors(%d)\n got:%#v\nwant:%#v", tc.input, actual, tc.expected) } }) @@ -28,23 +28,3 @@ func BenchmarkPrimeFactors(b *testing.B) { } } } - -func slicesEqual(a, b []int64) bool { - if len(a) != len(b) { - return false - } - - for i := 0; i < len(a); i++ { - if a[i] != b[i] { - return false - } - } - - return true -} - -func ascending(list []int64) func(int, int) bool { - return func(i, j int) bool { - return list[i] < list[j] - } -}