Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch protection #22

Open
iHiD opened this issue Jul 6, 2023 · 7 comments
Open

Branch protection #22

iHiD opened this issue Jul 6, 2023 · 7 comments

Comments

@iHiD
Copy link
Member

iHiD commented Jul 6, 2023

I'd like to add branch protection here (it's standard across all exercism repos). The only change would be that all commits would need to go via PRs (but you could still self-merge) and that that we could add CI requirements.

Any objections? And any CI you'd like me to add as a requirement?

(cc @ErikSchierboom to action once @lpil has replied :))

@lpil
Copy link
Member

lpil commented Jul 10, 2023

Sounds good!!

@ErikSchierboom
Copy link
Member

I've added branch protection to the main branch. You'll now be required to merge things via PRs (which you did anyway). The only other thing I added was that the CI workflow must be green in order for the PR to be mergeable. That okay with you?

@lpil
Copy link
Member

lpil commented Jul 13, 2023

Yup, perfect. Thank you

@lpil
Copy link
Member

lpil commented Jul 16, 2023

Could you disable the required review from @/exercism/maintainers-admin please? The Gleam team not being able to merge has been a big hit to productivity today.

@iHiD
Copy link
Member Author

iHiD commented Jul 18, 2023

@lpil I'm happy to yes. But be aware that you'll be pretty much the only track without this extra guard. The reason we have it is so that if stuff goes wrong, it ensures that one of me/Erik are around to revert things and/or get logs out etc.

@ErikSchierboom
Copy link
Member

Done

@lpil
Copy link
Member

lpil commented Jul 18, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants