Sync acronym with problem-specifications (#548)

* Rectify tests.toml for acronym

This removes unimplemented test cases from the test.toml
for the acronym exercise.

* Remove extraneous test in acronym

This deletes a test that doesn't have an equivalent spec
in the canonical-data of problem-specifications.

* Normalize test descriptions in acronym

This updates the test descriptions to match those in the
canonical-data in problem-specifications.

* Sync acronym with problem-specifications

This brings in changes to the instructions, adds several tests,
and normalizes the config.json file for the exercise.

* Attempt to fix failing test

I haven't gotten C++ working locally yet; leaning on CI.

Author: kytrinyx

exercises/practice/acronym/.docs/instructions.md

@@ -4,5 +4,14 @@ Convert a phrase to its acronym.
 
 Techies love their TLA (Three Letter Acronyms)!
 
-Help generate some jargon by writing a program that converts a long name
-like Portable Network Graphics to its acronym (PNG).
+Help generate some jargon by writing a program that converts a long name like Portable Network Graphics to its acronym (PNG).
+
+Punctuation is handled as follows: hyphens are word separators (like whitespace); all other punctuation can be removed from the input.
+
+For example:
+
+|Input|Output|
+|-|-|
+|As Soon As Possible|ASAP|
+|Liquid-crystal display|LCD|
+|Thank George It's Friday!|TGIF|

exercises/practice/acronym/.meta/config.json

@@ -1,12 +1,12 @@
 {
-  "blurb": "Convert a long phrase to its acronym",
   "authors": [
     "chgraef"
   ],
   "contributors": [
     "elyashiv",
     "KevinWMatthews",
-    "patricksjackson"
+    "patricksjackson",
+    "kytrinyx"
   ],
   "files": {
     "solution": [
@@ -21,6 +21,7 @@
       ".meta/example.h"
     ]
   },
+  "blurb": "Convert a long phrase to its acronym.",
   "source": "Julien Vanier",
   "source_url": "https://github.com/monkbroc"
 }

exercises/practice/acronym/.meta/example.cpp

@@ -7,7 +7,7 @@ namespace acronym {
 
 string acronym(string const &input_str) {
     string acronym_str;
-    string delimiters = " :-,";
+    string delimiters = " :-,_";
     enum DelimiterState { NOT_FOUND, FOUND };
     DelimiterState delimiter_state = FOUND;
     for (char c : input_str) {

exercises/practice/acronym/.meta/tests.toml

@@ -1,6 +1,13 @@
-# This is an auto-generated file. Regular comments will be removed when this
-# file is regenerated. Regenerating will not touch any manually added keys,
-# so comments can be added in a "comment" key.
+# This is an auto-generated file.
+#
+# Regenerating this file via `configlet sync` will:
+# - Recreate every `description` key/value pair
+# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications
+# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion)
+# - Preserve any other key/value pair
+#
+# As user-added comments (using the # character) will be removed when this file
+# is regenerated, comments can be added via a `comment` key.
 
 [1e22cceb-c5e4-4562-9afe-aef07ad1eaf4]
 description = "basic"

exercises/practice/acronym/acronym_test.cpp

@@ -35,31 +35,57 @@ TEST_CASE("punctuation")
     REQUIRE(expected == actual);
 }
 
-TEST_CASE("all_caps_words")
+TEST_CASE("all_caps_word")
 {
-    const string actual = acronym::acronym("PHP: Hypertext Preprocessor");
+    const string actual = acronym::acronym("GNU Image Manipulation Program");
 
-    const string expected{"PHP"};
+    const string expected{"GIMP"};
 
     REQUIRE(expected == actual);
 }
 
-TEST_CASE("non_acronym_all_caps_word")
+TEST_CASE("punctuation_without_whitespace")
 {
-    const string actual = acronym::acronym("GNU Image Manipulation Program");
+    const string actual = acronym::acronym("Complementary metal-oxide semiconductor");
 
-    const string expected{"GIMP"};
+    const string expected{"CMOS"};
 
     REQUIRE(expected == actual);
 }
 
-TEST_CASE("hyphenated")
+TEST_CASE("very_long_abbreviation")
 {
-    const string actual = acronym::acronym("Complementary metal-oxide semiconductor");
+    const string actual = acronym::acronym("Rolling On The Floor Laughing So Hard That My Dogs Came Over And Licked Me");
 
-    const string expected{"CMOS"};
+    const string expected{"ROTFLSHTMDCOALM"};
 
     REQUIRE(expected == actual);
 }
 
+TEST_CASE("consecutive_delimiters")
+{
+    const string actual = acronym::acronym("Something - I made up from thin air");
+
+    const string expected{"SIMUFTA"};
+
+    REQUIRE(expected == actual);
+}
+
+TEST_CASE("apostrophes")
+{
+    const string actual = acronym::acronym("Halley's Comet");
+
+    const string expected{"HC"};
+
+    REQUIRE(expected == actual);
+}
+
+TEST_CASE("underscore_emphasis")
+{
+    const string actual = acronym::acronym("The Road _Not_ Taken");
+
+    const string expected{"TRNT"};
+
+    REQUIRE(expected == actual);
+}
 #endif