Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when using "search" as a filename #16

Open
mmcky opened this issue Sep 30, 2020 · 5 comments
Open

Issue when using "search" as a filename #16

mmcky opened this issue Sep 30, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@mmcky
Copy link
Member

mmcky commented Sep 30, 2020

Describe the bug

When building html it seems that if you use search as a filename -- sphinx replaces it with a search page and ignores the content in that file. Perhaps this is a reserved additional page for sphinx?

If _toc.yml contains:

- file: search

the issue occurs.

However if the file is nested in a folder there is no issue.

- file: folder/search

also other names such as my_search don't face the issue.

A minimal example is available here

To Reproduce

Clone minimal example

and jb build ./

with html

Expected behavior

Either a warning for using a special filename or use the user provided file.

Environment

▶ jb --version
Jupyter Book: 0.8.2
MyST-NB: 0.10.1
Sphinx Book Theme: 0.0.37
MyST-Parser: 0.12.10
Jupyter-Cache: 0.4.1
NbClient: 0.5.0
@choldgraf
Copy link
Member

ah yeah - I feel like this is an annoying Sphinx bug that has bitten me before too. Perhaps a warning is the right way to go here, so that users know why things are breaking 👍

@mmcky
Copy link
Member Author

mmcky commented Oct 1, 2020

I think another one -- but a lot less likely to occur is genindex

@chrisjsewell chrisjsewell transferred this issue from jupyter-book/jupyter-book Apr 8, 2021
@chrisjsewell chrisjsewell added the enhancement New feature or request label Apr 16, 2021
@AllenDowney
Copy link

This issue just took a couple of hours of my life that I won't get back, so it might be worth a warning :)

@mmcky
Copy link
Member Author

mmcky commented Jan 3, 2022

thanks for the feedback @AllenDowney -- sorry about the lost hours. Love your books!
I'll see if we can put a warning check in place for this into jupyter-book as a reserved filename.

  • add warning and check for special sphinx filenames

@AllenDowney
Copy link

Thanks, @mmcky !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants