We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
context
When adding a output to a ipywidgets widget, e.g. a <table class=table>…</table> to a VBox, the resulting style partially ignores dark mode.
<table class=table>…</table>
VBox
expectation I expected tables and ipywidget UI to be dark-mode aware.
I expect CSS for cell output to never use hardcoded colors, but always CSS variables.
bug But instead light-on-dark elements appear in the cell output
problem This is a problem because it’s ugly and every second line is unreadable.
See https://github.com/flying-sheep/session-info2/blob/da3827c26259211e3a0d2effa9695422436fe562/src/session_info2/_widget.py#L39-L43
Which results in this HTML: https://session-info2.readthedocs.io/en/latest/
Specifically this applies:
div.cell_output tbody tr:nth-child(odd) { background: #f5f5f5; }
Please never use hardcoded colors in CSS, only variables
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the bug
context
When adding a output to a ipywidgets widget, e.g. a
<table class=table>…</table>
to aVBox
, the resulting style partially ignores dark mode.expectation
I expected tables and ipywidget UI to be dark-mode aware.
I expect CSS for cell output to never use hardcoded colors, but always CSS variables.
bug
But instead light-on-dark elements appear in the cell output
problem
This is a problem because it’s ugly and every second line is unreadable.
Reproduce the bug
See https://github.com/flying-sheep/session-info2/blob/da3827c26259211e3a0d2effa9695422436fe562/src/session_info2/_widget.py#L39-L43
Which results in this HTML: https://session-info2.readthedocs.io/en/latest/
Specifically this applies:
Please never use hardcoded colors in CSS, only variables
List your environment
The text was updated successfully, but these errors were encountered: