Skip to content

Commit 68f761e

Browse files
Print warning when a tab job does no work
TODO: this should be fleshed out more if we end up actually wanting it
1 parent 5ae919c commit 68f761e

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

lasercut/join.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ def tab_join_create_tab_on_face(material_face, material_plane, width, pos_y, tab
162162

163163
def make_tab_join(tab, tab_part, other_parts):
164164
slots_pos = get_slot_positions(tab)
165+
did_any_work = False
165166
for i, y in enumerate(slots_pos):
166167
for part_interactor in other_parts:
167168
tab_to_add, tab_dog_bone = tab_join_create_tab_on_face(tab_part.properties, part_interactor.properties,
@@ -170,13 +171,17 @@ def make_tab_join(tab, tab_part, other_parts):
170171
part_interactor.properties)
171172

172173
if intersect_test:
174+
did_any_work = True
173175
tab_part.toAdd.append(tab_to_add_transformed)
174176
if tab_dog_bone:
175177
tab_part.toRemove.append(helper.transform_part(tab_dog_bone, tab))
176178
hole = helper.tab_join_create_hole_on_plane(tab, tab.tabs_width, y, tab_part.properties,
177179
part_interactor.properties, tab.dog_bone)
178180
part_interactor.toRemove.append(helper.transform_part(hole, tab))
179181
break
182+
183+
if not did_any_work:
184+
FreeCAD.Console.PrintWarning("Tab on part " + tab_part.get_name() + " did not apply\n")
180185
return
181186

182187

0 commit comments

Comments
 (0)