Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "+" character removed while searching #68

Closed
NitroSniper opened this issue Jan 19, 2024 · 2 comments
Closed

[BUG] "+" character removed while searching #68

NitroSniper opened this issue Jan 19, 2024 · 2 comments
Assignees

Comments

@NitroSniper
Copy link
Contributor

NitroSniper commented Jan 19, 2024

Describe The Bug

When searching with the + character anywhere in the buffer. It will be removed when searching which can change the normal results. Even force search will have this issue.

To Reproduce

Steps to reproduce the behavior:

  1. Go to StartPage
  2. Search either:
  • "How to do string split in c++" => How to do string split in c
  • "(3 + 4) + (4 + 3)" => "(3 4) (4 3)"
  1. You'll see current search result being changed

Expected Behavior

For the search result to not be changed

Specs

  • OS: Window 10 & Arch Linux
  • Browser: Firefox 121
@excalith
Copy link
Owner

Hey @NitroSniper!

Nice catch, I need to use encodeURIComponent to properly encode the string in order to work with requests.

The string should be encoded to ouput something like this in order for engines to properly handle symbols:

https://www.google.com/search?q=How%20to%20do%20string%20split%20in%20c%2B%2B

Will start working on it as soon as possible and release as a hotfix when it is ready.

Cheers!

@excalith
Copy link
Owner

Fixed with PR #69, releasing the hotfix as 3.1.2 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants