Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 in esl-utils]: update or deprecate isBot detector according to latest tool updates #2996

Closed
ala-n opened this issue Mar 17, 2025 · 2 comments · Fixed by #3012
Closed
Assignees

Comments

@ala-n
Copy link
Collaborator

ala-n commented Mar 17, 2025

Update or deprecate isBot detector of the 'esl-utils/environment' according to the latest tool updates.
Use Google Bot as one of the references.

@fshovchko
Copy link
Contributor

@ala-n,
In my opinion, we probably shouldn't deprecate the utility. It still may have its uses. But it should be definitely updated.
The google's dev docs have the list of crawlers they have. Also they have a special case crawlers when there's an agreement between crawled site and bot described here. In general, almost all of the crawlers start with Googlebot in name except a couple.

Btw, here's the regex we use on our analytics project: /headless|Googlebot|Bingbot|Slurp|DuckDuckBot|Baiduspider|YandexBot|Sogou|Exabot|facebot|ia_archiver|spider|SeznamBot|PetalBot|63.0.3239.0|Yeti|coccocbot|applebot/i

@ala-n
Copy link
Collaborator Author

ala-n commented Mar 24, 2025

Discussion result:

  • Usage in ESL (forbid upper screen DPR detection) - retire, we should get rid of isBot Check inside @nx ESLMediaQueries
  • Deprecate isBot usage (Reason: it is no longer ESL lib scope, actual bot check should be consistently updated and much more complex than a couple of bot providers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants