Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatalError() not acceptable in production code #13

Open
neilt opened this issue May 28, 2024 · 0 comments
Open

fatalError() not acceptable in production code #13

neilt opened this issue May 28, 2024 · 0 comments

Comments

@neilt
Copy link

neilt commented May 28, 2024

There are 8 cases of fatalError() in the non-test code. This is really not acceptable for production code.

There are several remedies:

  1. These really are coding errors. I don't understand the code well enough yet to know, but if that is the case and since these are all related to knownCharacteristics, then the fatalError() message should include the the known characteristics. However, since known characteristics are specific to a device I don't see how this is the correct solution.
  2. Replace fatalError()s with correct error handling code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant