Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Turn into trait #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Turn into trait #29

wants to merge 1 commit into from

Conversation

axic
Copy link
Member

@axic axic commented Dec 5, 2018

Closes #5.

@jakelang
Copy link
Member

jakelang commented Dec 6, 2018

Needs to be rebased.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@axic
Copy link
Member Author

axic commented Dec 6, 2018

This is an old branch I turned into a PR so that it is not just lost. We can close the PR if it makes sen.

@jakelang
Copy link
Member

jakelang commented Dec 6, 2018

@axic do you want to build on this? or just rewrite the PR

@axic
Copy link
Member Author

axic commented Dec 6, 2018

It can be cleaned up if we agree on an approach.

@axic axic force-pushed the turn-into-trait branch 4 times, most recently from 4142537 to c8afdcd Compare February 14, 2019 13:35
@axic axic force-pushed the turn-into-trait branch 2 times, most recently from d21dcb6 to 84fe70b Compare May 28, 2019 14:54
@axic
Copy link
Member Author

axic commented May 28, 2019

@jakelang @s1na updated this, it may be a good start now.

src/lib.rs Outdated Show resolved Hide resolved
@axic
Copy link
Member Author

axic commented May 28, 2019

Updates properly with current types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn ewasm_api into a trait
2 participants