From 2c088db82b2b7c6478bd984d75953e834fca8bbc Mon Sep 17 00:00:00 2001
From: Julia Ogris
Date: Sat, 24 Aug 2024 14:33:16 +1000
Subject: [PATCH] tools: Upgrade Playwright
Upgrade Playwright to latest version and slightly updated upgrade docs again
to use node with `--prefix` flag like we did in the previous commit.
Like documented, we ran
npx --prefix e2e -y npm-check-updates --packageFile e2e/package.json -u
npm --prefix e2e install
npx --prefix e2e playwright install
manually upgraded the Docker image used in the Makefile and manually tested
the upgrade with `make e2e USE_DOCKER=1`.
---
Makefile | 2 +-
docs/development/upgrade.md | 7 +++----
e2e/package-lock.json | 26 ++++++++++++-------------
e2e/package.json | 4 ++--
frontend/docs/development/upgrade.html | 7 +++----
frontend/docs/development/upgrade.htmlf | 7 +++----
6 files changed, 25 insertions(+), 28 deletions(-)
diff --git a/Makefile b/Makefile
index 142876ef..a79cf7f0 100644
--- a/Makefile
+++ b/Makefile
@@ -223,7 +223,7 @@ define PLAYWRIGHT_CMD_LOCAL
npx --prefix e2e playwright test --config e2e $(PLAYWRIGHT_ARGS)
endef
-PLAYWRIGHT_OCI_IMAGE = mcr.microsoft.com/playwright:v1.46.0-jammy
+PLAYWRIGHT_OCI_IMAGE = mcr.microsoft.com/playwright:v1.46.1-jammy
PLAYWRIGHT_CMD_DOCKER = docker run --rm \
--volume $$(pwd):/work/ -w /work/ \
--user $(shell id -u):$(shell id -g) \
diff --git a/docs/development/upgrade.md b/docs/development/upgrade.md
index 2e2c5d22..2124402b 100644
--- a/docs/development/upgrade.md
+++ b/docs/development/upgrade.md
@@ -85,10 +85,9 @@ We use [Playwright] for automated end-to-end and browser testing.
From the repository root directory run
- cd e2e
- npx -y npm-check-updates -u
- npm install
- npx playwright install
+ npx --prefix e2e -y npm-check-updates --packageFile e2e/package.json -u
+ npm --prefix e2e install
+ npx --prefix e2e playwright install
If a new version of Playwright has been installed, also update the Docker image
version of Playwright used in Makefile and on CI.
diff --git a/e2e/package-lock.json b/e2e/package-lock.json
index 497226e3..d798a64e 100644
--- a/e2e/package-lock.json
+++ b/e2e/package-lock.json
@@ -5,18 +5,18 @@
"packages": {
"": {
"devDependencies": {
- "@playwright/test": "^1.46.0",
- "playwright": "^1.46.0"
+ "@playwright/test": "^1.46.1",
+ "playwright": "^1.46.1"
}
},
"node_modules/@playwright/test": {
- "version": "1.46.0",
- "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.46.0.tgz",
- "integrity": "sha512-/QYft5VArOrGRP5pgkrfKksqsKA6CEFyGQ/gjNe6q0y4tZ1aaPfq4gIjudr1s3D+pXyrPRdsy4opKDrjBabE5w==",
+ "version": "1.46.1",
+ "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.46.1.tgz",
+ "integrity": "sha512-Fq6SwLujA/DOIvNC2EL/SojJnkKf/rAwJ//APpJJHRyMi1PdKrY3Az+4XNQ51N4RTbItbIByQ0jgd1tayq1aeA==",
"dev": true,
"license": "Apache-2.0",
"dependencies": {
- "playwright": "1.46.0"
+ "playwright": "1.46.1"
},
"bin": {
"playwright": "cli.js"
@@ -41,13 +41,13 @@
}
},
"node_modules/playwright": {
- "version": "1.46.0",
- "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.46.0.tgz",
- "integrity": "sha512-XYJ5WvfefWONh1uPAUAi0H2xXV5S3vrtcnXe6uAOgdGi3aSpqOSXX08IAjXW34xitfuOJsvXU5anXZxPSEQiJw==",
+ "version": "1.46.1",
+ "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.46.1.tgz",
+ "integrity": "sha512-oPcr1yqoXLCkgKtD5eNUPLiN40rYEM39odNpIb6VE6S7/15gJmA1NzVv6zJYusV0e7tzvkU/utBFNa/Kpxmwng==",
"dev": true,
"license": "Apache-2.0",
"dependencies": {
- "playwright-core": "1.46.0"
+ "playwright-core": "1.46.1"
},
"bin": {
"playwright": "cli.js"
@@ -60,9 +60,9 @@
}
},
"node_modules/playwright-core": {
- "version": "1.46.0",
- "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.46.0.tgz",
- "integrity": "sha512-9Y/d5UIwuJk8t3+lhmMSAJyNP1BUC/DqP3cQJDQQL/oWqAiuPTLgy7Q5dzglmTLwcBRdetzgNM/gni7ckfTr6A==",
+ "version": "1.46.1",
+ "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.46.1.tgz",
+ "integrity": "sha512-h9LqIQaAv+CYvWzsZ+h3RsrqCStkBHlgo6/TJlFst3cOTlLghBQlJwPOZKQJTKNaD3QIB7aAVQ+gfWbN3NXB7A==",
"dev": true,
"license": "Apache-2.0",
"bin": {
diff --git a/e2e/package.json b/e2e/package.json
index 681bba60..69b5fb3c 100644
--- a/e2e/package.json
+++ b/e2e/package.json
@@ -1,7 +1,7 @@
{
"private": "true",
"devDependencies": {
- "@playwright/test": "^1.46.0",
- "playwright": "^1.46.0"
+ "@playwright/test": "^1.46.1",
+ "playwright": "^1.46.1"
}
}
diff --git a/frontend/docs/development/upgrade.html b/frontend/docs/development/upgrade.html
index b9e1ffb2..2c40e80e 100644
--- a/frontend/docs/development/upgrade.html
+++ b/frontend/docs/development/upgrade.html
@@ -142,10 +142,9 @@
browser testing.
From the repository root directory run
- cd e2e
-npx -y npm-check-updates -u
-npm install
-npx playwright install
+ npx --prefix e2e -y npm-check-updates --packageFile e2e/package.json -u
+npm --prefix e2e install
+npx --prefix e2e playwright install
If a new version of Playwright has been installed, also update the Docker image version of
diff --git a/frontend/docs/development/upgrade.htmlf b/frontend/docs/development/upgrade.htmlf
index 81ae7d7c..233d408c 100644
--- a/frontend/docs/development/upgrade.htmlf
+++ b/frontend/docs/development/upgrade.htmlf
@@ -84,10 +84,9 @@ npm --prefix .hermit/node install
testing.
From the repository root directory run
-cd e2e
-npx -y npm-check-updates -u
-npm install
-npx playwright install
+npx --prefix e2e -y npm-check-updates --packageFile e2e/package.json -u
+npm --prefix e2e install
+npx --prefix e2e playwright install
If a new version of Playwright has been installed, also update the Docker image version of