-
Notifications
You must be signed in to change notification settings - Fork 241
refactor: replace interface{} with any for clarity and modernization #2781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: reddaisyy <[email protected]>
Summary of ChangesHello @reddaisyy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the Go codebase by adopting the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request modernizes the codebase by replacing interface{} with its alias any, introduced in Go 1.18. The changes are applied consistently across the DA visualization server, its tests, and the blob decoder tool. This refactoring improves code clarity and aligns with modern Go practices. The changes are correct and I have no further suggestions.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2781 +/- ##
==========================================
+ Coverage 61.57% 62.86% +1.28%
==========================================
Files 82 82
Lines 8715 6912 -1803
==========================================
- Hits 5366 4345 -1021
+ Misses 2845 2063 -782
Partials 504 504
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* main: fix: make signature verification backwards compatible (#2782) chore: adding upgrade test for evm-single (#2780) refactor: replace interface{} with any for clarity and modernization (#2781) feat: replay mechanism to sync node with execution layer (#2771) docs: update readme for sync pkg (#2776) build(deps): Bump the all-go group across 6 directories with 4 updates (#2772) refactor: remove obsolete // +build tag (#2774) build(deps): Bump vite from 5.4.20 to 5.4.21 in /docs in the npm_and_yarn group across 1 directory (#2775) build(deps): Bump actions/setup-node from 5 to 6 (#2773)
…2829) <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. Ex: Closes #<issue number> --> Inspired by #2781 and replace all. This change replaces occurrences of interface{} with the predeclared identifier any, introduced in Go 1.18 as an alias for interface{}. As noted in the [Go 1.18 Release Notes](https://go.dev/doc/go1.18#language): This improves readability and aligns the codebase with modern Go conventions. Signed-off-by: promalert <[email protected]>
…2829) <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. Ex: Closes #<issue number> --> Inspired by #2781 and replace all. This change replaces occurrences of interface{} with the predeclared identifier any, introduced in Go 1.18 as an alias for interface{}. As noted in the [Go 1.18 Release Notes](https://go.dev/doc/go1.18#language): This improves readability and aligns the codebase with modern Go conventions. Signed-off-by: promalert <[email protected]>
Overview
This change replaces occurrences of interface{} with the predeclared identifier any, introduced in Go 1.18 as an alias for interface{}.
As noted in the Go 1.18 Release Notes:
This improves readability and aligns the codebase with modern Go conventions.