Skip to content

Conversation

@wyrapeseed
Copy link
Contributor

Overview

From Go 1.17, the preferred syntax for build constraints is //go:build,
which replaces the old // +build form. The old style is now considered
deprecated but still supported for backward compatibility.

This change removes the obsolete // +build xxx line, keeping only the
modern //go:build xxx directive.

More info: golang/go#41184 and https://go.dev/doc/go1.17#build-lines

Design Doc / Proposal:
https://go.dev/design/draft-gobuild

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @wyrapeseed, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors several Go script files by updating their build constraint syntax. It systematically removes the deprecated // +build directives, retaining only the modern //go:build format. This change improves code maintainability and ensures compatibility with current Go language standards, as the older syntax is considered obsolete since Go 1.17.

Highlights

  • Deprecated Build Tag Removal: The pull request removes the obsolete // +build tags from several Go script files, aligning with modern Go practices.
  • Modern Go Syntax Adoption: It ensures that only the preferred //go:build syntax, introduced in Go 1.17, is used for build constraints.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the obsolete // +build tags from several Go script files. This change aligns with modern Go practices, as the // +build syntax has been deprecated since Go 1.17 in favor of //go:build. Given that the project's go.mod file specifies Go 1.24.6, this cleanup is appropriate and improves code maintainability by removing legacy syntax. The changes are correct and I have no further comments.

@tac0turtle tac0turtle enabled auto-merge October 21, 2025 08:26
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.26%. Comparing base (0dba4e7) to head (f50b73e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2774   +/-   ##
=======================================
  Coverage   61.26%   61.26%           
=======================================
  Files          81       81           
  Lines        8589     8589           
=======================================
  Hits         5262     5262           
  Misses       2830     2830           
  Partials      497      497           
Flag Coverage Δ
combined 61.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tac0turtle tac0turtle added this pull request to the merge queue Oct 21, 2025
Merged via the queue into evstack:main with commit 2e65332 Oct 21, 2025
23 of 28 checks passed
@github-project-automation github-project-automation bot moved this to Done in Evolve Oct 21, 2025
alpe added a commit that referenced this pull request Oct 28, 2025
* main:
  fix: make signature verification backwards compatible  (#2782)
  chore: adding upgrade test for evm-single (#2780)
  refactor: replace interface{} with any for clarity and modernization (#2781)
  feat: replay mechanism to sync node with execution layer (#2771)
  docs: update readme for sync pkg (#2776)
  build(deps): Bump the all-go group across 6 directories with 4 updates (#2772)
  refactor:  remove obsolete // +build tag (#2774)
  build(deps): Bump vite from 5.4.20 to 5.4.21 in /docs in the npm_and_yarn group across 1 directory (#2775)
  build(deps): Bump actions/setup-node from 5 to 6 (#2773)
@claude claude bot mentioned this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants