-
Notifications
You must be signed in to change notification settings - Fork 241
refactor: remove obsolete // +build tag #2774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: wyrapeseed <[email protected]>
Summary of ChangesHello @wyrapeseed, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors several Go script files by updating their build constraint syntax. It systematically removes the deprecated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes the obsolete // +build tags from several Go script files. This change aligns with modern Go practices, as the // +build syntax has been deprecated since Go 1.17 in favor of //go:build. Given that the project's go.mod file specifies Go 1.24.6, this cleanup is appropriate and improves code maintainability by removing legacy syntax. The changes are correct and I have no further comments.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2774 +/- ##
=======================================
Coverage 61.26% 61.26%
=======================================
Files 81 81
Lines 8589 8589
=======================================
Hits 5262 5262
Misses 2830 2830
Partials 497 497
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* main: fix: make signature verification backwards compatible (#2782) chore: adding upgrade test for evm-single (#2780) refactor: replace interface{} with any for clarity and modernization (#2781) feat: replay mechanism to sync node with execution layer (#2771) docs: update readme for sync pkg (#2776) build(deps): Bump the all-go group across 6 directories with 4 updates (#2772) refactor: remove obsolete // +build tag (#2774) build(deps): Bump vite from 5.4.20 to 5.4.21 in /docs in the npm_and_yarn group across 1 directory (#2775) build(deps): Bump actions/setup-node from 5 to 6 (#2773)
Overview
From Go 1.17, the preferred syntax for build constraints is
//go:build,which replaces the old
// +buildform. The old style is now considereddeprecated but still supported for backward compatibility.
This change removes the obsolete
// +build xxxline, keeping only themodern
//go:build xxxdirective.More info: golang/go#41184 and https://go.dev/doc/go1.17#build-lines
Design Doc / Proposal:
https://go.dev/design/draft-gobuild