You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am very much looking forward to get to use #52 in production. So much in fact, that I have been using a private fork for quite some time now, since there has been no official release so far. The point of this issue is not to pressure you into cutting a new release.
To be able to use this addon as a direct Git dependency, which is useful for trying out unreleased features or fixes, you either have to apply the above patch or push a built version.
Since you're not using any ES features that aren't natively supported on the latest version of Node, enabling direct, untranspiled usage is no problem.
I think the cleanest solution is to add a symlink lib/index.js to src/index.js or a js file that re-exports src/index.js for maximum OS compatibility, and then remove that file during the build step.
Would you accept such a PR?
The text was updated successfully, but these errors were encountered:
I am very much looking forward to get to use #52 in production. So much in fact, that I have been using a private fork for quite some time now, since there has been no official release so far. The point of this issue is not to pressure you into cutting a new release.
The reason I'm opening this issue, is this diff buschtoens@a9b6f76
Because of this build step here:
https://github.com/ivanvotti/ember-svg-jar/blob/bbec727607a7f0f80f82ea2a5692079a1050b63a/package.json#L24
To be able to use this addon as a direct Git dependency, which is useful for trying out unreleased features or fixes, you either have to apply the above patch or push a built version.
Since you're not using any ES features that aren't natively supported on the latest version of Node, enabling direct, untranspiled usage is no problem.
I think the cleanest solution is to add a symlink
lib/index.js
tosrc/index.js
or a js file that re-exportssrc/index.js
for maximum OS compatibility, and then remove that file during the build step.Would you accept such a PR?
The text was updated successfully, but these errors were encountered: