Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Engines #109

Open
gokatz opened this issue Nov 1, 2018 · 1 comment
Open

Support Engines #109

gokatz opened this issue Nov 1, 2018 · 1 comment

Comments

@gokatz
Copy link

gokatz commented Nov 1, 2018

I would be great if we could produce different output files for each engine and bundle those with the engine's vendor bundle and of course, the common files can go with the app's bundle.

@GCheung55
Copy link

Recently I worked on an engine that uses svg-jar using the symbols strategy. The only way I could get svg-jar to work in an engine was to include the path to the engine's SVG's files in thesvgJar configuration of the host apps ember-cli-build.js file. Without this configuration in the host app, the symbols would not be included and injected into the app's index.html.

I tried to configure svgJar in the engine, which did output a symbols.svg file, however, it's not loaded. Engines use ember-asset-loader to load assets, such as JS and CSS. In order to load symbols.svg, I think a SVG loader must be "registered" with the asset-loader service and manifestOptions.supportedTypes must include svg. I need to dig further to determine where I can configure the manifestOptions in an engine.

Also, the engine's symbols.svg file isn't de-dupped with the one the host app outputs. There's a chance for name collisions, as well as an increase in file sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants