Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump btcd version #1488

Merged
merged 6 commits into from
Mar 22, 2023
Merged

deps: bump btcd version #1488

merged 6 commits into from
Mar 22, 2023

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Mar 21, 2023

Description

  • Bump btcd version to v0.23.3
  • Remove archived dependency github.com/miguelmota/go-ethereum-hdwallet because was using an old btcd version and it's no longer maintained
  • Imported functions from removed dependency for tests on crypto/hd pkg

Closes #XXX

@GAtom22 GAtom22 marked this pull request as ready for review March 21, 2023 19:31
@GAtom22 GAtom22 requested a review from a team as a code owner March 21, 2023 19:31
@GAtom22 GAtom22 requested review from 0a1c, facs95, Vvaradinov and MalteHerrmann and removed request for a team March 21, 2023 19:31
@GAtom22
Copy link
Contributor Author

GAtom22 commented Mar 21, 2023

Lint issues addressed on #1487

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #1488 (85b4cb7) into main (6ad3076) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 85b4cb7 differs from pull request most recent head 8ecbd5d. Consider uploading reports for the commit 8ecbd5d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1488      +/-   ##
==========================================
- Coverage   73.08%   73.07%   -0.02%     
==========================================
  Files         268      268              
  Lines       18446    18449       +3     
==========================================
  Hits        13481    13481              
- Misses       4365     4368       +3     
  Partials      600      600              
Impacted Files Coverage Δ
crypto/hd/algorithm.go 73.33% <ø> (ø)
tests/e2e/upgrade/manager.go 0.00% <0.00%> (ø)

@GAtom22 GAtom22 enabled auto-merge (squash) March 22, 2023 15:16
@GAtom22 GAtom22 merged commit 267adcd into main Mar 22, 2023
@GAtom22 GAtom22 deleted the GAtom22/deps branch March 22, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants